Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage analysis in CI #351

Merged
merged 2 commits into from
Oct 9, 2021
Merged

Fix code coverage analysis in CI #351

merged 2 commits into from
Oct 9, 2021

Conversation

sagebind
Copy link
Owner

@sagebind sagebind commented Oct 8, 2021

Fix code coverage step in CI erroring. It seems like the primary issue here is Tarpaulin is trying to run doc tests annotated with no_run, which aren't necessarily designed to pass. Just disable doc tests in Tarpaulin to work around this since they don't contribute much to the overall code coverage anyway. I suspect a new Cargo or Rust version at some point caused this issue.

See also xd009642/tarpaulin#848.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #351 (e586d6c) into master (422d4b0) will decrease coverage by 3.75%.
The diff coverage is 28.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   75.32%   71.57%   -3.76%     
==========================================
  Files          59       60       +1     
  Lines        3218     3261      +43     
==========================================
- Hits         2424     2334      -90     
- Misses        794      927     +133     
Impacted Files Coverage Δ
src/macros.rs 100.00% <ø> (ø)
testserver/src/server.rs 0.00% <0.00%> (ø)
src/body/mod.rs 83.17% <16.66%> (+0.93%) ⬆️
src/body/sync.rs 81.18% <25.00%> (-1.00%) ⬇️
src/error.rs 49.71% <40.00%> (-1.15%) ⬇️
src/client.rs 69.75% <100.00%> (-3.56%) ⬇️
tests/response_body.rs 100.00% <100.00%> (ø)
src/config/dns.rs 0.00% <0.00%> (-36.37%) ⬇️
src/config/mod.rs 44.02% <0.00%> (-30.10%) ⬇️
src/config/ssl.rs 18.75% <0.00%> (-16.25%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e8b60...e586d6c. Read the comment docs.

@sagebind sagebind marked this pull request as ready for review October 9, 2021 00:17
@sagebind sagebind merged commit 319b544 into master Oct 9, 2021
@sagebind sagebind deleted the fix-tarpaulin branch October 9, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant