Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return true for Body::is_empty for HEAD responses #343

Merged
merged 1 commit into from
Sep 5, 2021

Conversation

sagebind
Copy link
Owner

Fixes #341.

@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #343 (8a9a5c5) into master (422d4b0) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   75.32%   75.09%   -0.24%     
==========================================
  Files          59       59              
  Lines        3218     3228      +10     
==========================================
  Hits         2424     2424              
- Misses        794      804      +10     
Impacted Files Coverage Δ
src/client.rs 74.55% <100.00%> (+1.24%) ⬆️
tests/response_body.rs 100.00% <100.00%> (ø)
src/cookies/psl/mod.rs 80.48% <0.00%> (-2.44%) ⬇️
src/agent/mod.rs 70.73% <0.00%> (-2.44%) ⬇️
src/redirect.rs 69.04% <0.00%> (-1.55%) ⬇️
src/config/request.rs 73.97% <0.00%> (-1.37%) ⬇️
testserver/src/mock.rs 79.22% <0.00%> (-1.30%) ⬇️
src/agent/selector.rs 73.25% <0.00%> (-1.17%) ⬇️
src/error.rs 49.71% <0.00%> (-1.15%) ⬇️
src/body/sync.rs 81.18% <0.00%> (-1.00%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422d4b0...8a9a5c5. Read the comment docs.

@sagebind sagebind merged commit ca24e04 into master Sep 5, 2021
@sagebind sagebind deleted the 341-head-response-should-be-empty branch September 5, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

head requests with content length fail
1 participant