Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: delay chainChanged event in test wallet #3859

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Fix: delay chainChanged event in test wallet #3859

merged 1 commit into from
Jun 21, 2024

Conversation

katspaugh
Copy link
Member

What it solves

Onboard cannot subscribe to the chainChanged event if it's emitted synchronously right after connecting.
Giving it a small delay allows onboard to subscribe to this event and fetch an ENS name and account balance of the connected address.

@katspaugh katspaugh requested a review from mike10ca June 21, 2024 10:25
Copy link

github-actions bot commented Jun 21, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1003.8 KB (-19 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.15% (+0.02% 🔼)
11592/14645
🔴 Branches
58.41% (+0.01% 🔼)
2810/4811
🟡 Functions
66.07% (-0.02% 🔻)
1856/2809
🟢 Lines
80.48% (+0.02% 🔼)
10450/12984

Test suite run success

1446 tests passing in 199 suites.

Report generated by 🧪jest coverage report action from 3b67c9a

@katspaugh katspaugh merged commit e47d108 into dev Jun 21, 2024
14 checks passed
@katspaugh katspaugh deleted the test-wallet branch June 21, 2024 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant