Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update release action #3739

Merged
merged 3 commits into from
May 24, 2024
Merged

Chore: update release action #3739

merged 3 commits into from
May 24, 2024

Conversation

katspaugh
Copy link
Member

What it solves

The action actions/upload-release-asset@v1 stopped working and it's not maintained, so I replaced it with Shopify/upload-to-release@v1. See https://github.com/marketplace/actions/upload-to-release-action

Copy link

github-actions bot commented May 24, 2024

Copy link

github-actions bot commented May 24, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented May 24, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented May 24, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.26% 11630/14673
🔴 Branches
58.16% (+0.01% 🔼)
2754/4735
🟡 Functions
66.31% (-0.02% 🔻)
1864/2811
🟢 Lines 80.62% 10481/13001
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / usePendingTxs.ts
89.58%
83.33% (+0.98% 🔼)
90.91% (-1.4% 🔻)
92.5%

Test suite run success

1463 tests passing in 202 suites.

Report generated by 🧪jest coverage report action from 531b5dc

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on a separate repo but getting an error that it can't find the v1 package.
Screenshot 2024-05-24 at 10 36 18

Using the v2.0.0 package works though.
Screenshot 2024-05-24 at 10 37 18

.github/workflows/deploy-production.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-production.yml Outdated Show resolved Hide resolved
@katspaugh katspaugh merged commit 72a2018 into dev May 24, 2024
14 checks passed
@katspaugh katspaugh deleted the checksum branch May 24, 2024 09:08
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants