Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change array<int...> to list<...> in PHP doc #103

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Nov 15, 2023

I found this PR again today (2024-04-18!).
It looks like I did something reasonable, but, TBH, I don't remember what caused me to start doing this sort of minor refactoring of the PHPdoc.

Maybe we did this already in other sabre repos? I would have to search around to find it.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (93732bd) to head (c7c408f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files           1        1           
  Lines         174      174           
=======================================
  Hits          170      170           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis phil-davis marked this pull request as ready for review April 18, 2024 11:20
@phil-davis phil-davis requested a review from staabm April 18, 2024 11:21
Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case it looks harmless and fine.

when changing types in api methods we need to be more careful, because lists have a few more implications then just beeing a array with a int key.

@phil-davis phil-davis merged commit 0e66035 into sabre-io:master Apr 18, 2024
7 checks passed
@phil-davis phil-davis deleted the phpdoc-list branch April 18, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants