Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release 7.0.2 #213

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 27, 2023

This should not break any consumer. For anyone already using v7, it will report some types more accurately and so their consumer-code will be better analyzed by phpstan.

Note: most consumers will currently be using sabre/http along with sabre/dav and other sabre-io components. So the dependency requirements of the current sabre/dav 4.4.0 will pull in sabre/http 5.1.7 anyway. So there are probably not many projects using sabre/http major version 7 yet anyway.

Eventually I will work through the type-declarations and phpstan level 9 throughout the sabre-io repos - I have some work in vobject that I need to get back to, and then try the main sabre/dav repo. And then we can do a set of major releases of all that...

@phil-davis phil-davis self-assigned this Jun 27, 2023
@phil-davis phil-davis requested a review from staabm June 27, 2023 10:38
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #213 (ecf945f) into master (5220b2b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #213   +/-   ##
=========================================
  Coverage     94.21%   94.21%           
  Complexity      260      260           
=========================================
  Files            15       15           
  Lines           881      881           
=========================================
  Hits            830      830           
  Misses           51       51           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phil-davis phil-davis merged commit 591a497 into sabre-io:master Jun 27, 2023
6 checks passed
@phil-davis phil-davis deleted the prepare-7.0.2 branch June 27, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant