Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not break any consumer. For anyone already using v7, it will report some types more accurately and so their consumer-code will be better analyzed by phpstan.
Note: most consumers will currently be using
sabre/http
along withsabre/dav
and other sabre-io components. So the dependency requirements of the currentsabre/dav
4.4.0 will pull insabre/http
5.1.7 anyway. So there are probably not many projects usingsabre/http
major version 7 yet anyway.Eventually I will work through the type-declarations and phpstan level 9 throughout the sabre-io repos - I have some work in
vobject
that I need to get back to, and then try the mainsabre/dav
repo. And then we can do a set of major releases of all that...