Don't throw a Notice in calculateUri when passing an empty uri #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Feb 1, 2017
| @@ -565,7 +565,7 @@ function getRequestUri() { | |||
| */ | |||
| function calculateUri($uri) { | |||
|
|
|||
| if ($uri[0] != '/' && strpos($uri, ':https://')) { | |||
| if ($uri != '' && $uri[0] != '/' && strpos($uri, ':https://')) { | |||
There was a problem hiding this comment.
which uri do you expect calculateUri to return for this new case? please add a unit test for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dav server listening on the root of a domain receives a request to the root of that domain, the request $uri will be an empty string.
Besides the one Notice that was thrown the rest of the implementation works correctly in that case ($uri = '', $baseUri = '/')