Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-time): enable dynamic time zone #1257

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix(app-time): enable dynamic time zone #1257

merged 1 commit into from
Apr 17, 2024

Conversation

sabertazimi
Copy link
Owner

Pull Request

This PR Contains

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Test-Case

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Breaking Changes

Additional Info

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 11:55pm

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Lighthouse Report

https://blog-fyqrw4cnl-sabertazs-projects.vercel.app/

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 94
🟢 accessibility 100
🟡 best-practices 78
🟢 seo 100
🟢 pwa 100

https://blog-fyqrw4cnl-sabertazs-projects.vercel.app/posts

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 97
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

https://blog-fyqrw4cnl-sabertazs-projects.vercel.app/tags

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 100
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

https://blog-fyqrw4cnl-sabertazs-projects.vercel.app/books

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 100
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

https://blog-fyqrw4cnl-sabertazs-projects.vercel.app/about

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 100
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (4293781) to head (81efb1e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
+ Coverage   95.73%   95.74%   +0.01%     
==========================================
  Files         176      177       +1     
  Lines         844      846       +2     
  Branches       87       87              
==========================================
+ Hits          808      810       +2     
  Misses         31       31              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hydrate time zone from client side to avoid static time zone issue
(always time zone vercel server located).
@sabertazimi sabertazimi merged commit 56228d2 into main Apr 17, 2024
15 checks passed
@sabertazimi sabertazimi deleted the fix/time branch April 17, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant