Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOFLOW-31] Unit testing and coverage are missing #31

Open
giorgiozoppi opened this issue Nov 20, 2022 · 6 comments
Open

[GOFLOW-31] Unit testing and coverage are missing #31

giorgiozoppi opened this issue Nov 20, 2022 · 6 comments
Assignees
Labels

Comments

@giorgiozoppi
Copy link
Collaborator

Goflow: Unit testing and coverage

Goal

Provide a 95% unit test mocking where it's opportune with gomock. No tests are present in the current code base.

@s8sg
Copy link
Owner

s8sg commented Mar 11, 2023

@giorgiozoppi This is where I need help. I didn't had enough bandwidth to look at the project recently.
What I'm thinking is s simplify a lot of implementation and add test

Do you have any idea how we can start ?

@giorgiozoppi
Copy link
Collaborator Author

giorgiozoppi commented Mar 11, 2023

I would start from the lower level possibile. Is that the datastore? I also use this way of doing tickets for matching branches.

@giorgiozoppi giorgiozoppi changed the title Unit testing and coverage are missing [GOFLOW-31] Unit testing and coverage are missing Mar 11, 2023
@s8sg s8sg added good first issue Good for newcomers HighPriority labels Mar 11, 2023
@s8sg
Copy link
Owner

s8sg commented Mar 11, 2023

We need to test this first
https://github.com/s8sg/goflow/tree/master/core/sdk

This has all core functionalities

@giorgiozoppi
Copy link
Collaborator Author

Ok, i branch out, please use the same schema to rename different issues. The name of teh banch will be feature/goflow-31-unit-testing.

@s8sg
Copy link
Owner

s8sg commented Mar 11, 2023 via email

@giorgiozoppi
Copy link
Collaborator Author

Branched out, i start working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants