Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support publishing for ColorCodeField widget #65

Conversation

nqhhdev
Copy link
Contributor

@nqhhdev nqhhdev commented Apr 1, 2023

Hi Rydmike,

In my project, I used your library and I feel it is very good. Thanks for contributing to flutter community.
However, because my project needs some other logic, I want to use more ColorCodeField widget. Can you publish that widget?

Thank you very much.

@rydmike
Copy link
Owner

rydmike commented Apr 2, 2023

Looks good, other than that it enlarges the public API I don't see a reason why not. I'll take a closer look later today, merge and verify all is OK after it, and release a new version if everything checks out.

I hope to have some time to work on major new release of the color picker soonish, have so many things I want to add to it.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (2f0029e) 66.44% compared to head (c8d5a83) 66.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   66.44%   66.42%   -0.02%     
==========================================
  Files          23       23              
  Lines        2077     2076       -1     
==========================================
- Hits         1380     1379       -1     
  Misses        697      697              
Impacted Files Coverage Δ
lib/src/widgets/color_code_field.dart 64.34% <ø> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nqhhdev
Copy link
Contributor Author

nqhhdev commented Apr 2, 2023

Looks good, other than that it enlarges the public API I don't see a reason why not. I'll take a closer look later today, merge and verify all is OK after it, and release a new version if everything checks out.

I hope to have some time to work on major new release of the color picker soonish, have so many things I want to add to it.

Thank you for your feedback, I hope you can approve it soon.
If you have any comments about PR please tell me.

@rydmike
Copy link
Owner

rydmike commented Apr 2, 2023

Merged and updated package published. CI/CD is building new versions of WEB demo at the moment, takes a few minutes, sometimes even 30 minutes, but not important for using the package right away. Pub:s package analysis can also take 30 mins or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants