Optimize Shadeeelection update #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Sulisong thanks for the contribution and pull request, based on a quick look it seems OK and like a good one to have. I will test it properly before I merge it and release a new version of the package on pub.dev. I will let you know soon if I have any questions or find something that needs needs to be addressed before I merge it. Kicking myself a bit now for not writing full test coverage for this package yet 😃 (like I have done for flex_color_scheme.) |
rydmike
approved these changes
Jun 11, 2021
rydmike
added a commit
that referenced
this pull request
Jun 11, 2021
rydmike
added a commit
that referenced
this pull request
Jun 11, 2021
|
@Sulisong just as info, this PR among a few other things is in release 2.0.2 on pub.dev. Thanks for your contribution. |
Thank you for developing a good project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.