Skip to content

Commit

Permalink
FIX: InheritedTheme.capture
Browse files Browse the repository at this point in the history
When using custom transitions the `InheritedTheme.capture` should use `actionButtons.useRootNavigator` and not default it to true. Fixed.

Add TODO for more 3.4.0 feature to changelog
  • Loading branch information
rydmike committed Jan 26, 2024
1 parent 8601ab2 commit 2359f45
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,21 @@ All notable changes to the **FlexColorPicker** package are documented in this fi

## 3.4.0 (WIP)

**Jan 21, 2024**
**Jan 26, 2024**

**NEW**

- Add transparent color options (Work in progress, not yet fully implemented).

**TODO**
- Add enum values `filled` and `filledTonal` to `ColorPickerActionButtonType` and support for these styles as OK/Cancel buttons.
- Add `dialogActionOnlyOK` to `ColorPickerActionButtons`. Default to false. If set to true and `dialogActionButtons` is true, only the OK button will be shown.
- Add `OkButtonUseSelectedColor` to `ColorPickerActionButtons`. Defaults to false. If true, the OK button will use the selected color as its color, instead of the default color. This is useful if you want to use the OK button to show the selected color

**FIX**

- Web demo: Reset to defaults did not reset settings for wheelSquarePadding and wheelSquareBorderRadius. Fixed.
- When using custom transitions the `InheritedTheme.capture ` should use `actionButtons.useRootNavigator` and not default it to true. Fixed.


## 3.3.1
Expand Down
2 changes: 1 addition & 1 deletion example/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ subprojects {
project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
tasks.register("clean", Delete) {
delete rootProject.buildDir
}
2 changes: 1 addition & 1 deletion example/android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\:https://services.gradle.org/distributions/gradle-6.7-all.zip
distributionUrl=https\:https://services.gradle.org/distributions/gradle-7.6.1-all.zip
2 changes: 1 addition & 1 deletion lib/src/color_picker.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,7 @@ class ColorPicker extends StatefulWidget {
from: context,
to: Navigator.of(
context,
rootNavigator: true,
rootNavigator: actionButtons.useRootNavigator,
).context,
);
if (useSafeArea) {
Expand Down

0 comments on commit 2359f45

Please sign in to comment.