fix(dom-expressions): handle expression in ref

[mdynnl]

fixes solidjs/solid#2137

these are still relevant here so didn't touch them

let refTarget;
const template8 = <div ref={refTarget} />;

const template10 = <div ref={refFactory()} />;

not sure why the check for call expression was there though.

[SarguelUnda]

Posting here to not flood the issue we came from.

As a general case I understand your point. I was today year old when I realised that props?.ref isn't lhs aswell.

Isn't there an argument to transform props?.ref into props.ref to get the optimisation of the lvalcond instead of the more general use function that your merge request propose ?

[SarguelUnda]

Moreover if props.ref is not à function your fix doesn't work either no ?

[mdynnl]

dom-expressions/packages/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/attributeExpressions/code.js

Line 65 in ac40fb8

const template10 = <div ref={refFactory()} />;

transforms to

dom-expressions/packages/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/attributeExpressions/output.js

Lines 170 to 175 in ac40fb8

	const template10 = (() => {
	var _el$16 = _tmpl$4();
	var _ref$3 = refFactory();
	typeof _ref$3 === "function" && _$use(_ref$3, _el$16);
	return _el$16;
	})();

and because of this

dom-expressions/packages/babel-plugin-jsx-dom-expressions/src/dom/element.js

Line 498 in ac40fb8

} else if (t.isCallExpression(value.expression)) {

it only works for a call expression,

but it should work for anything that isn't a literal, let variable, member expression.

[ryansolid]

Yeah I think you are right. I probably was fixing a specific issue and was looking too narrow. That being said the fact this change hasn't changed the output of any tests suggests to me are definitely missing some tests we should have.

[ryansolid]

Thank you for adding the tests. Much appreciated.