This repository has been archived by the owner on Jun 19, 2019. It is now read-only.
Windows permission change before unlinking files and symlinks is in and has better tests. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive permissions being removed properly.
ryanmcgrath
pushed a commit
that referenced
this pull request
Jan 17, 2014
Windows permission change before unlinking files and symlinks is in and has better tests.
|
Should be good to go now, @seanmwalker. npm'd. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows permission change before unlinking files and symlinks is in and has better tests.
Windows systems need to have read/write permissions to support the deletion. We now chmod them which just flips the read/write bits in the end. But it enables the process to work.