feat(webview): Add custom protocol (scheme) support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a basic implementation of the custom protocol, with built-in mimetype extraction from the content, backed by URI detection. To make it clear, I added an example and can be run with: ``` cargo run --example webview_custom_protocol --features webview ```
|
Ah, this is super cool. I think the only thing I'm curious about - can we make I think everything else in here could be merged, really appreciate it! |
|
Here we go! Glad you think it'll be useful! |
|
Merged! Hella appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic implementation of the custom protocol (scheme)
To make it clear, I added an example and can be run with:
Screen.Recording.2021-04-25.at.12.09.29.PM.mov