Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Rails Engine to show the letters if you are not running locally #12

Closed
wants to merge 1 commit into from

Conversation

alexrothenberg
Copy link

What do you think of adding a Rails Engine to this gem so it can be used on a non-local server where launchy wont work? This engine adds a route so https://your.app.com/letter_opener will show a very simple inbox and each letter can also be viewed.

I'm not really sure how to test an engine so I only wrote a spec for the model and unfortunately have none for the controller or routes.

This gem is a great idea and came just when I needed it!

@ryanb
Copy link
Owner

ryanb commented Sep 13, 2011

This is something I would definitely like to do. I want to first focus on bug fixes and minor improvements, but once that is solid I'll pull this in. Thanks!

@alexrothenberg
Copy link
Author

Sounds good. I'll sit tight until then.

@krisleech
Copy link

I'm using the branch from @alexrothenberg on staging and I can confirm it works well.

@ryanb
Copy link
Owner

ryanb commented Oct 1, 2012

Closing this since I want to keep letter_opener simple and lightweight. However I would love to see this as a separate gem. Maybe called "remote_letter_opener"? It could use this gem as a dependency and just override the delivery method behavior and add an engine.

@ryanb ryanb closed this Oct 1, 2012
@ryanb ryanb mentioned this pull request Oct 1, 2012
@fgrehm
Copy link
Contributor

fgrehm commented Jan 4, 2013

Hey guys, I've just release a pretty basic gem to do that: https://github.com/fgrehm/letter_opener_web

@nashby
Copy link
Collaborator

nashby commented Jan 4, 2013

Awesome! Could you please add a note about this gem to letter_opener's
README?

On Fri, Jan 4, 2013 at 5:41 PM, Fabio Rehm [email protected] wrote:

Hey guys, I've just release a pretty basic gem to do that:
https://github.com/fgrehm/letter_opener_web


Reply to this email directly or view it on GitHubhttps://github.com//pull/12#issuecomment-11884801.

@fgrehm
Copy link
Contributor

fgrehm commented Jan 4, 2013

Done #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants