-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File names with comma no longer work #261
Comments
Maybe the separator should be configurable. I notice that Cantaloupe also has multi-page functionality, but uses a semi-colon rather than a comma (https://cantaloupe-project.github.io/manual/5.0/images.html#Identifiers). Would a semi-colon be better? Or perhaps some other symbol? What other kinds of punctuation do you have in your image names? |
I think making it configurable (like in Cantaloupe, which we switched from :)) is probably ideal (even just a (I'm unfortunately not sure what kinds of punctuation we use in file names, but we used the default |
…ack slice selection. Now disabled by default unless IIIF_DELIMITER is set. Resolves: #261
This should now be fixed. I've added a new IIIF_DELIMITER configuration parameter where you can specify exactly the kind of IIIF delimiter you want, which can be a character or even any arbitrary string. This feature is disabled by default and only activated if you set the IIIF_DELIMITER parameter. |
Yep, it works fine now. Thank you! |
d978bfd "[a]dded ability to choose a particular page or slice in an image stack when using IIIF by using a comma delimitter after the file name", but unfortunately this breaks file names that contain
,
, because the request URI isn't parsed correctly -- the comma and everything after it is chopped off from the file name in the decoding/filtering step, and is instead interpreted as a request for a certain page or slice.Given the file
/data/foo,bar.jp2
:Previously (6f3a93d):
Since d978bfd:
The text was updated successfully, but these errors were encountered: