Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default features of libc #647

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

alexcrichton
Copy link
Contributor

No need for it to be activated as std isn't a necessary dependency!
Should help out with no_std projects in some situations.

No need for it to be activated as `std` isn't a necessary dependency!
Should help out with `no_std` projects in some situations.
@dhardy
Copy link
Member

dhardy commented Nov 20, 2018

All this does is link in required dependencies? Should we make our std feature depend on libc/use_std? Maybe it makes no difference.

@alexcrichton
Copy link
Contributor Author

Nah the use_std feature of libc isn't off-by-default for weird historical reasons. In theory all crates can unconditionally depend on libc with the feature turned off, so there's no need to conditionally turn it on.

@dhardy dhardy merged commit 3eadab7 into rust-random:master Nov 20, 2018
@alexcrichton
Copy link
Contributor Author

Thanks! I'm hoping to leverage this in a different PR soon, so would it be possible to release a bugfix release w/ this in it?

@alexcrichton alexcrichton deleted the no-std-libc branch November 20, 2018 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants