Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary mut #276

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Remove unnecessary mut #276

merged 1 commit into from
Mar 1, 2018

Conversation

pitdicker
Copy link
Contributor

This gives a warning on rust 1.22.0. Somehow not on later versions, but I have encountered other cases before where rust's detection of unused mut's regressed.

@dhardy
Copy link
Member

dhardy commented Mar 1, 2018

Ah, I assumed this was just because .to_le() optimised to nothing on an LE CPU, but this passes on BE too.

@dhardy dhardy merged commit 5f77fb2 into rust-random:master Mar 1, 2018
@pitdicker pitdicker deleted the unused_mut branch March 1, 2018 18:34
pitdicker pushed a commit that referenced this pull request Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants