Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes from experimental branch #273

Merged
merged 5 commits into from
Feb 28, 2018
Merged

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Feb 27, 2018

This is a collection of small changes from my master branch, plus one more (new module for EntropyRng).

  • remove next_f32 / 64 — this isn't strictly necessary, but has been discussed and it seems unlikely we'd ever use them (in theory dSFMT is faster, but in practice I suspect not a lot, since random bits from simulation-grade RNGs are cheap and likely outweighed by other operations in most simulations)
  • add CryptoRng — also discussed, and requested by a few people even though it neither does nor guarantees anything
  • some house-keeping

Copy link
Contributor

@pitdicker pitdicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree with all these changes! Actually wanted to do the same 😄. Feel free to merge from me. You wanted to remove the first commit?

@dhardy
Copy link
Member Author

dhardy commented Feb 28, 2018

I don't mind; it's just this and your PR conflict over that bit.

@dhardy
Copy link
Member Author

dhardy commented Feb 28, 2018

Okay, I'll merge this. It would be nice to have my first commit merged then your work on top of that I guess.

@dhardy dhardy merged commit 3402373 into rust-random:master Feb 28, 2018
@dhardy dhardy deleted the next-float branch March 14, 2018 16:40
pitdicker pushed a commit that referenced this pull request Apr 4, 2018
Small changes from experimental branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants