-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github Actions CI for the master branch #192
Conversation
afd8bf4
to
b572e0e
Compare
9f0c3b1
to
43149ab
Compare
@newpavlov This is ready for review, let me know what you think. Right now we will run 6 tests on |
I changed the test matrix to only run
I don't think there's a huge advantage to testing things like Our entire CI now runs in < 3 minutes, with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Do we still need the .cargo/config
file? Also maybe it's worth to move test modules from src/
to tests/
?
This allows us to automatically ignore lints that are incompatible with our MSRV. Signed-off-by: Joe Richey <[email protected]>
- Cleanup `tests.yml` - Add better binary downloads - Add minimal dependancies check - Add tests for `custom` feature - Build/Link for iOS - Run cross tests on aarch64 linux and Android - Link on Solaris and Netbsd - Test wasm code on Node, Chrome, Firefox - Test WASI - No need for RDRAND feature on VxWorks Signed-off-by: Joe Richey <[email protected]>
Most of the advantages from testing various Rust versions already come from running those tests on Linux and Windows. There's very little gain from also running these tests on macOS, while macOS jobs are the slowest to schedule. Signed-off-by: Joe Richey <[email protected]>
Signed-off-by: Joe Richey <[email protected]>
This is what allows us to use
Good idea, I did this in a separate PR, see: 28cafca |
Fixes #181 and adds a bunch of stuff to the CI
-Z build-std=core
instead ofxbuild
tests.yml
custom
featureThe following TODOs will be done in a follow up PR:
aarch64-apple-darwin
binaries (aka "Apple Silicon")