add case of libstd fix from Stacked Borrows #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I forgot about this list, good catch! But we also have a list at https://github.com/rust-lang/miri#bugs-found-by-miri, which is better maintained. Maybe it would make more sense to link there instead? (Looks like this one is also missing from that list, though.) |
Then I will close this PR and make a PR to Miri 👍 |
|
@JOE1994 thanks. :) Can you also do a PR here to link to Miri instead of having a separate list? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new case to the list of
'adjustments made to libstd (due to Stacked Borrows violation)'.
A small fix was made to libstd in rust-lang/rust#70479 (back in March).
(Miri reported UB due to Stacked Borrows violation - link to Miri error log)
Thank you for reviewing 👍