-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize armv8 neon instruction set on aarch64 #1266
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
45dcf31
test a few stabilization and correct some assert_instr
SparrowLii 269dfba
stabilize aarch64/neon/mod.rs and arm_shared/neon/mod.rs
SparrowLii c2840ee
stabilize aarch64/neon/generated.rs and arm_shared/neon/generated.rs
SparrowLii 34cf17a
correct fmt
SparrowLii 5b8e8e6
correct scope of stabilization
SparrowLii 634cd27
use static_assert in vext
SparrowLii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
correct scope of stabilization
- Loading branch information
commit 5b8e8e65b831debb0ae2c005e0e8c7e76509be3e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,23 +11,20 @@ use stdarch_test::assert_instr; | |
/// Reverse the order of the bytes. | ||
#[inline] | ||
#[cfg_attr(test, assert_instr(rev))] | ||
#[stable(feature = "neon_intrinsics", since = "1.59.0")] | ||
pub unsafe fn _rev_u64(x: u64) -> u64 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, there intrinsics are not covered by the FCP. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK. Unmarked it. |
||
x.swap_bytes() as u64 | ||
} | ||
|
||
/// Count Leading Zeros. | ||
#[inline] | ||
#[cfg_attr(test, assert_instr(clz))] | ||
#[stable(feature = "neon_intrinsics", since = "1.59.0")] | ||
pub unsafe fn _clz_u64(x: u64) -> u64 { | ||
x.leading_zeros() as u64 | ||
} | ||
|
||
/// Reverse the bit order. | ||
#[inline] | ||
#[cfg_attr(test, assert_instr(rbit))] | ||
#[stable(feature = "neon_intrinsics", since = "1.59.0")] | ||
pub unsafe fn _rbit_u64(x: u64) -> u64 { | ||
crate::intrinsics::bitreverse(x) | ||
} | ||
|
@@ -38,7 +35,6 @@ pub unsafe fn _rbit_u64(x: u64) -> u64 { | |
/// bits. | ||
#[inline] | ||
#[cfg_attr(test, assert_instr(cls))] | ||
#[stable(feature = "neon_intrinsics", since = "1.59.0")] | ||
pub unsafe fn _cls_u32(x: u32) -> u32 { | ||
u32::leading_zeros((((((x as i32) >> 31) as u32) ^ x) << 1) | 1) as u32 | ||
} | ||
|
@@ -49,7 +45,6 @@ pub unsafe fn _cls_u32(x: u32) -> u32 { | |
/// bits. | ||
#[inline] | ||
#[cfg_attr(test, assert_instr(cls))] | ||
#[stable(feature = "neon_intrinsics", since = "1.59.0")] | ||
pub unsafe fn _cls_u64(x: u64) -> u64 { | ||
u64::leading_zeros((((((x as i64) >> 63) as u64) ^ x) << 1) | 1) as u64 | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FCP only covers the NEON (SIMD) intrinsics, not crc intrinsics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Unmarked it.