-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vita #465
Add support for vita #465
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with merging this, but I don't think we can officially support it at this time.
Any way we can set up CI for this? Running cargo test
or cargo check
?
No official support is fine for me, it's a tier 3 platform after all :)
AFAIK there's currently no way to run tests right now. Check works using: cargo +nightly check -Z build-std=std --target armv7-sony-vita-newlibeabihf So we could add |
That sounds good. You can copy what I removed in 14be1bc |
Some tests are failing, because on vita there's no setsockopt(fd, libc::SOL_SOCKET, libc::SO_NONBLOCK, nonblocking as libc::c_int) |
Converted this PR to draft as we (vita-rust community) are still figuring some things out |
At this point PR can be undrafted when rust-lang/libc#3284 is merged and released (we will need to bump libc version here for a green pipeline). |
Update crate version to 0.2.149 Contains fixes for net structs/calls for Vita target - #3284 and #3366. Required for rust-lang/socket2/pull/465
So, we're finally ready 😇
|
Don't run tests for properties not available Added CI, fixed tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change has to be reverted as it's unsound. The other comments are small points.
Other than that I think this on the way to get merged.
Fixed all the comments, please check. With the API change I shouldn't have trusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
Also forgot to say that I like the CI setup.
Thanks @nikarh |
Needs rust-lang/libc#3284 to compile