fix(exercises): Does not follow the function naming convention snake_case #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuesongbj
changed the title
snake_case
xuesongbj
changed the title
snake_case
xuesongbj
changed the title
xuesongbj
changed the title
xuesongbj
changed the title
|
In this case it'd be okay to change the offending function names too, since it's against convention and may confuse people that encounter it. |
|
is_FooBar rename is_foo_bar ? @diannasoriel |
|
If the problem is not fixed, there is a warning message |
Yes, that sounds right. |
|
Yes, I also encountered this warning problem. when will this commit merge into master branch? @diannasoriel |
|
Again, I would rather fix the problem properly than rely on suppressing the warning. Therefore, changing the non-snake-case function names to snake-case names would be the correct solution here. |
|
Has been modified according to snake-case: |
shadows-withal
approved these changes
Oct 18, 2021
|
@all-contributors please add @xuesongbj for content |
|
@diannasoriel I've put up a pull request to add @xuesongbj! 🎉 |
catull
pushed a commit
to catull/rustlings
that referenced
this pull request
Oct 21, 2021
Co-authored-by: zhangshaozhi <[email protected]>
bugaolengdeyuxiaoer
pushed a commit
to bugaolengdeyuxiaoer/rustlings
that referenced
this pull request
Dec 28, 2021
Co-authored-by: zhangshaozhi <[email protected]>
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
Co-authored-by: zhangshaozhi <[email protected]>
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
Co-authored-by: zhangshaozhi <[email protected]>
Spacebody
pushed a commit
to Spacebody/my-rustlings
that referenced
this pull request
Nov 18, 2022
Co-authored-by: zhangshaozhi <[email protected]>
ComixHe
pushed a commit
to ComixHe/rustlings
that referenced
this pull request
Jun 20, 2023
Co-authored-by: zhangshaozhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exercise does not follow the snake_case specification, cargo test has the following warning:
warning: function
is_FooBarshould have a snake case name.To ensure the meaning is correct, try to add allow non_snake_case.