Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): stop littering .pdb files on windows #1697

Conversation

docwilco
Copy link
Contributor

On Windows, rustc creates a .pdb file in addition to the compiler output file. Using -C strip=debuginfo prevents the compiler from generating said file, and saves users quite some diskspace.

@docwilco
Copy link
Contributor Author

Alternatively, could also clean up .pdb in clean():

    #[cfg(target_os = "windows")]
    let _ignored = remove_file(format!("{}.pdb", temp_file()));

Copy link
Member

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shadows-withal shadows-withal merged commit 579735b into rust-lang:main Sep 28, 2023
5 checks passed
@shadows-withal
Copy link
Member

@all-contributors please add @docwilco for content

@allcontributors
Copy link
Contributor

@shadows-withal

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 65573

@shadows-withal
Copy link
Member

oops, let's try again

@all-contributors please add @docwilco for code

@allcontributors
Copy link
Contributor

@shadows-withal

I've put up a pull request to add @docwilco! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants