-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #96123
Rollup of 7 pull requests #96123
Conversation
Parse inner attributes on inline const block According to rust-lang#84414 (comment), inner attributes are intended to be supported *"in all containers for statements (or some subset of statements)"*. This PR adds inner attribute parsing and pretty-printing for inline const blocks (rust-lang#76001), which contain statements just like an unsafe block or a loop body. ```rust let _ = const { #![allow(...)] let x = (); x }; ```
…eywiser Reject `#[thread_local]` attribute on non-static items
…oli-obk Include Refs in Valtree Creation This adds references to `const_to_valtree`, which isn't used in the compiler yet, but after the previous changes we made to the thir and mir representations and this change we should be able to finally introduce them in the next PR. I wasn't able to properly test this code, except indirectly by including a call of `const_to_valtree` in the code that currently creates constants (`turn_into_const_value`). r? `@lcnr` cc `@oli-obk` `@RalfJung`
…inline, r=oli-obk Inline `shallow_resolve_ty` into `ShallowResolver` addresses fixme I found in infcx
separate flock implementations into separate modules The main benefit of doing this is that rustfmt will now format each of these modules.
Update mdbook This just brings in a few small fixes, particularly a rendering fix for chapter names with markdown in them (like the https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html page). There's also a minor fix for the search index for duplicate headings. Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0418
…id, r=notriddle rustdoc: Rename `def_id` into `item_id` when the type is `ItemId` for readability As `@notriddle` mentioned in rust-lang#96091, the field name is inaccurate. This PR fixes it by renaming it accordingly to its real type. r? `@notriddle`
@bors r+ rollup=never p=5 |
📌 Commit 10e0db5 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (878c783): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
visiting for weekly performance triage. all six regressions are on the same secondary benchmark: cachegrind diff report indicates that the blame might be placed on this (the top line entry in the diff report):
rustc_mir_build itself didn't change in this rollup. (Could the regression be explained by the valtree changes?) In any case, the narrow scope of the regression, the secondary nature of the regressed benchmark, the relatively low amount of regression, and the fact that this is in a rollup and thus fundamentally more difficuilt to tease apart, all adds up to: not worth the time to investigate further -- benefit/cost tradeoff is not worth it. @rustbot label: +perf-regression-triaged |
Successful merges:
#[thread_local]
attribute on non-static items #95006 (Reject#[thread_local]
attribute on non-static items)shallow_resolve_ty
intoShallowResolver
#95908 (Inlineshallow_resolve_ty
intoShallowResolver
)def_id
intoitem_id
when the type isItemId
for readability #96118 (rustdoc: Renamedef_id
intoitem_id
when the type isItemId
for readability)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup