-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move std::sys::{mutex, condvar, rwlock} to std::sys::locks. #95173
Conversation
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
Since this touches a lot of platform specific code: @bors rollup=iffy |
This comment has been minimized.
This comment has been minimized.
66b978d
to
724fd5a
Compare
@bors r+ |
📌 Commit 724fd5adae37c900812fa7b3a605a7f2fdde0939 has been approved by |
⌛ Testing commit 724fd5adae37c900812fa7b3a605a7f2fdde0939 with merge 25793f067828e33f969eca5702d804ea2220aa0a... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@rustbot author |
724fd5a
to
8ddb34d
Compare
@bors r=dtolnay |
📌 Commit 8ddb34d has been approved by |
Move std::sys::{mutex, condvar, rwlock} to std::sys::locks. This cleans up the the std::sys modules a bit by putting the locks in a single module called `locks` rather than spread over the three modules `mutex`, `condvar`, and `rwlock`. This makes it easier to organise lock implementations, which helps with rust-lang#93740.
⌛ Testing commit 8ddb34d with merge 2cff93665efc8cdc2e63b40fc01f8a24b2e78fee... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
8ddb34d
to
733153f
Compare
Third time's a charm? (: @bors r=dtolnay |
📌 Commit 733153f has been approved by |
@bors rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (36748cf): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This cleans up the the std::sys modules a bit by putting the locks in a single module called
locks
rather than spread over the three modulesmutex
,condvar
, andrwlock
. This makes it easier to organise lock implementations, which helps with #93740.