Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use implicit capture syntax in format_args" #95062

Closed
wants to merge 1 commit into from

Conversation

Dylan-DPC
Copy link
Member

This reverts #93950

part of diagnosis of perf regression in #94824

r? @ghost

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 18, 2022
@Dylan-DPC
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 18, 2022
@bors
Copy link
Contributor

bors commented Mar 18, 2022

⌛ Trying commit 7a40b31 with merge c1977ae272a2d0d09f7907dc9fd57776366e9ae2...

@bors
Copy link
Contributor

bors commented Mar 18, 2022

☀️ Try build successful - checks-actions
Build commit: c1977ae272a2d0d09f7907dc9fd57776366e9ae2 (c1977ae272a2d0d09f7907dc9fd57776366e9ae2)

@rust-timer
Copy link
Collaborator

Queued c1977ae272a2d0d09f7907dc9fd57776366e9ae2 with parent 4ca56d2, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c1977ae272a2d0d09f7907dc9fd57776366e9ae2): comparison url.

Summary: This benchmark run did not return any relevant results. 4 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 18, 2022
@Dylan-DPC Dylan-DPC marked this pull request as draft March 18, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants