-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reopen 91719 #94570
Reopen 91719 #94570
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon. Please see the contribution instructions for more information. |
Co-authored-by: Scott McMurray <[email protected]>
r? @workingjubilee |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
// CHECK-NEXT: ret i1 %[[EQ]] | ||
x == [0; 8] | ||
} | ||
|
||
// CHECK-LABEL: @array_eq_zero_long([1234 x i16]* | ||
#[no_mangle] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forget this when I suggested the codegen test.
@bors try |
⌛ Trying commit 0c13186 with merge 52b7c7ed6f087a5b756d1905d486240019ae4a29... |
☀️ Try build successful - checks-actions |
Queued 52b7c7ed6f087a5b756d1905d486240019ae4a29 with parent 10913c0, future comparison URL. |
Finished benchmarking commit (52b7c7ed6f087a5b756d1905d486240019ae4a29): comparison url. Summary: This benchmark run shows 111 relevant improvements 🎉 but 37 relevant regressions 😿 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
Excellent! To quote myself again: |
📌 Commit 0c13186 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b4bf56c): comparison url. Summary: This benchmark run shows 131 relevant improvements 🎉 but 28 relevant regressions 😿 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
Reopened #91719, which was closed inadvertently due to technical difficulties.