Deduplicate lines in long const-eval stack trace #92802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
4def9d8
to
73ad8df
Compare
|
It's not overkill. We already have two huge tests in our test suite showing this, albeit with mutual recursion. Not sure how we could catch mutual recursion properly... ideas? |
|
What are the tests that show a mutually-recursive trace? I could probably think of something more clever than this to detect those cases. Maybe some sort of windowed duplicate detection. |
|
I'll get around to this eventually... finding out how to print a nice output for repeating set of lines (N>1) is kinda hard. I have some ideas, but kinda lazy to write em out. @rustbot author |
|
@bors r+ rollup Until then, this is already a good improvement |
|
📌 Commit 73ad8df has been approved by |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 3, 2022
…race, r=oli-obk Deduplicate lines in long const-eval stack trace Lemme know if this is kinda overkill, lol. Fixes rust-lang#92796
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#92310 (rustdoc: Fix ICE report) - rust-lang#92802 (Deduplicate lines in long const-eval stack trace) - rust-lang#93515 (Factor convenience functions out of main printer implementation) - rust-lang#93566 (Make rustc use `RUST_BACKTRACE=full` by default) - rust-lang#93589 (Use Option::then in two places) - rust-lang#93600 (fix: Remove extra newlines from junit output) - rust-lang#93606 (Correct incorrect description of preorder traversals) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lemme know if this is kinda overkill, lol.
Fixes #92796