Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use guess_head_span in predicates_of for foreign span #88414

Merged
merged 1 commit into from
Aug 31, 2021

Commits on Aug 28, 2021

  1. Don't use guess_head_span in predicates_of for foreign span

    Previously, the result of `predicates_of` for a foreign trait
    would depend on the *current* state of the corresponding source
    file in the foreign crate. This could lead to ICEs during incremental
    compilation, since the on-disk contents of the upstream source file
    could potentially change without the upstream crate being recompiled.
    
    Additionally, this ensure that that the metadata we produce for a crate
    only depends on its *compiled* upstream dependencies (e.g an rlib or
    rmeta file), *not* the current on-disk state of the upstream crate
    source files.
    Aaron1011 committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    c9157ef View commit details
    Browse the repository at this point in the history