update const generics feature gates

[lcnr]

tl;dr: split const generics into three features: adt_const_params, const_generics_defaults and generic_const_exprs

continuing the work of @BoxyUwU in #88324, this PR

• renames feature(const_evaluatable_checked) to feature(generic_const_exprs) which now doesn't need any other feature gate to work. Previously feature(const_evaluatable_checked) was only useful in combination with feature(const_generics).
• completely removes feature(lazy_normalization_consts). This feature only supplied the parents generics to anonymous constants, which is pretty useless as generic anon consts are only allowed with feature(generic_const_exprs) anyways.
• moves the ability to use additional const param types from feature(const_generics) into feature(adt_const_params). As feature(const_generics) is now mostly useless without feature(generic_const_exprs) we also remove that feature flag.
• updates tests, removing duplicates and unnecessary revisions in some cases and also deletes all unused *.stderr files.

I not also remove the ordering restriction for const and type parameters if any of the three const generics features is active.
This ordering restriction feels like the only "real" use of the current feature(const_generics) right now so this change isn't a perfect solution, but as I intend to stabilize the ordering - and feature(const_generics_defaults) - in the very near future, I think this is acceptable for now.

---

cc @rust-lang/project-const-generics about the new feature names and this change in general.

I don't think we need any external approval for this change but I do intend to publish an update to the const generics tracking issue the day this PR lands, so I don't want this merged yet.

Apologies to whoever ends up reviewing this PR 😅 ❤️

r? rust-lang/project-const-generics

[rust-highfive]

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

[rust-highfive]

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

[bors]

☔ The latest upstream changes (presumably #87280) made this pull request unmergeable. Please resolve the merge conflicts.

[oli-obk]

@bors r+ p=1 (bitrotty)

[bors]

📌 Commit 18abdf4c3a902d0d9c86c4fa3cb78ecbd3534b91 has been approved by oli-obk

[oli-obk]

@bors r-

r=me

[flip1995]

Something looks really wrong with the Clippy changes. There are many stderr files that just got removed, which should be entirely unrelated to this PR.

Also this PR shows +910 −12,110, which just seems really sus.

[lcnr]

There are many stderr files that just got removed, which should be entirely unrelated to this PR.

During this PR i've removed all *.stderr files to prevent any leftover ones due to revision changes. This seems to also affect parts of clippy which are not relevant for CI. Reverted the clippy changes.

The reason for the large diff is that there were a bunch of nll revisions which have later been removed without removing the .nll.stderr files, so that explains most of the deleted lines of this PR.

Going to look through all changed files to check if there is anything else that's suspicious.

[lcnr]

Alright, I did remove stderr files of optionally ignored tests, so I added these back in. The remaining stderr files I've removed should all be from revisions which no longer exist. These missing stderr files would trigger a CI error when testing on the relevant platform, so it would have been fine to try and merge it as is.

[oli-obk]

@bors r+ p=1 (bitrotty)

[bors]

📌 Commit 68adb08aed0d319e71d55172288061ebdaa43343 has been approved by oli-obk

[flip1995]

Clippy changes LGTM now 👍 Thanks!

[bors]

📌 Commit 87e7817 has been approved by oli-obk

[bors]

⌛ Testing commit 87e7817 with merge 1f465c603f864dbf5951a154e8eb9d1b66f40d8e...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[lcnr]

this looks spurious again? not going to retry this PR right now as the bors queue seems to be quite full and I am not certain this is spurious

[jyn514]

x86_64-apple failed after 2 hours without logs

@bors retry

[bors]

⌛ Testing commit 87e7817 with merge 6f388bb...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 6f388bb to master...