Add doc aliases to fs.rs #86839
Add doc aliases to fs.rs #86839
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon. Please see the contribution instructions for more information. |
|
The libs team is currently working on a policy when doc aliases are appropriate. rust-lang/std-dev-guide#25 |
|
☔ The latest upstream changes (presumably #86891) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Based on the new doc alias policy, could you please drop the aliases for the |
|
@D1mon can you squash the commits? We don't allow merge commits, there's instructions in the dev guide: https://rustc-dev-guide.rust-lang.org/git.html#no-merge-policy |
|
I can't commit (merging is blocked). Maybe because i edit in github (without git clone)!? |
|
@bors squash (not sure if it works without an approval, but worth a shot) |
There was a problem hiding this comment.
Let's go ahead with bors-squashed, that feature has some bugs but it should just work at least.
The change itself follows https://std-dev-guide.rust-lang.org/documentation/doc-alias-policy.html so LGTM.
|
r? @JohnTitor @bors r+ rollup |
|
📌 Commit 0efd350 has been approved by |
Add doc aliases to fs.rs Add aliases for create_dir, create_dir_all, remove_dir, remove_dir_all
Add `mkdir` to `create_dir`, `rmdir` to `remove_dir`.
|
Okay, I've squashed them on my local, everything should be fine now. |
|
📌 Commit 387cd6d has been approved by |
Add doc aliases to fs.rs Add aliases for create_dir, create_dir_all, remove_dir, remove_dir_all
Rollup of 10 pull requests Successful merges: - rust-lang#81050 (Stabilize core::task::ready!) - rust-lang#81363 (Remove P: Unpin bound on impl Future for Pin) - rust-lang#86839 (Add doc aliases to fs.rs) - rust-lang#87435 (fix example code for E0617) - rust-lang#87451 (Add support for tuple struct field documentation) - rust-lang#87491 (Integrate context into the memorial to Anna) - rust-lang#87521 (Add long explanation for E0498) - rust-lang#87527 (Don't run MIR unsafeck at all when using `-Zthir-unsafeck`) - rust-lang#87550 (Add `CI_ONLY_WHEN_CHANNEL` and run `x86_64-gnu-stable` only on nightly) - rust-lang#87565 (Use backticks when referring to `core::future::Ready` in panic message) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Add aliases for create_dir, create_dir_all, remove_dir, remove_dir_all