Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable destination propagation on all mir-opt-levels #82684

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Mar 1, 2021

The new // compile-flags: -Zunsound-mir-opts are inserted without an extra newline to avoid introducing a large mir-opt diff.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2021
@rust-log-analyzer

This comment has been minimized.

@jonas-schievink
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 2, 2021

📌 Commit d8f8b68e64cf91ec726c171497afbb93ce1b4771 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2021
@matthiaskrgr
Copy link
Member

As I understand, this pr basically disables #78360
#78360 had perf implications and was thus marked as rollup=never so we should probably do the same with the revert.
@bors rollup=never

@tmiasko
Copy link
Contributor Author

tmiasko commented Mar 4, 2021

This PR disables destination propagation on all mir-opt-levels (it was already disabled on the default level). The changes from #78360 remain in effect.

@matthiaskrgr
Copy link
Member

Oh, sorry! :/

@matthiaskrgr
Copy link
Member

@bors rollup-

@bors
Copy link
Contributor

bors commented Mar 6, 2021

☔ The latest upstream changes (presumably #82816) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 6, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Mar 6, 2021

@bors r=jonas-schievink

@bors
Copy link
Contributor

bors commented Mar 6, 2021

@tmiasko: 🔑 Insufficient privileges: Not in reviewers

@bjorn3
Copy link
Member

bjorn3 commented Mar 6, 2021

@bors r=jonas-schievink

@bors
Copy link
Contributor

bors commented Mar 6, 2021

📌 Commit 6f49aad has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 8, 2021
Disable destination propagation on all mir-opt-levels

The new `// compile-flags: -Zunsound-mir-opts` are inserted without an extra newline to avoid introducing a large mir-opt diff.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 8, 2021
Disable destination propagation on all mir-opt-levels

The new `// compile-flags: -Zunsound-mir-opts` are inserted without an extra newline to avoid introducing a large mir-opt diff.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 8, 2021
Disable destination propagation on all mir-opt-levels

The new `// compile-flags: -Zunsound-mir-opts` are inserted without an extra newline to avoid introducing a large mir-opt diff.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 8, 2021
Disable destination propagation on all mir-opt-levels

The new `// compile-flags: -Zunsound-mir-opts` are inserted without an extra newline to avoid introducing a large mir-opt diff.
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#82047 (bypass auto_da_alloc for metadata files)
 - rust-lang#82415 (expand: Refactor module loading)
 - rust-lang#82557 (Add natvis for Result, NonNull, CString, CStr, and Cow)
 - rust-lang#82613 (Remove Item::kind, use tagged enum. Rename variants to match)
 - rust-lang#82642 (Fix jemalloc usage on OSX)
 - rust-lang#82682 (Implement built-in attribute macro `#[cfg_eval]` + some refactoring)
 - rust-lang#82684 (Disable destination propagation on all mir-opt-levels)
 - rust-lang#82755 (Refactor confirm_builtin_call, remove partial if)
 - rust-lang#82857 (Edit ructc_ast_lowering docs)
 - rust-lang#82862 (Generalize Write impl for Vec<u8> to Vec<u8, A>)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dd7a606 into rust-lang:master Mar 8, 2021
@tmiasko tmiasko deleted the dest-prop branch March 8, 2021 18:21
@cuviper cuviper added this to the 1.52.0 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants