Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix various aliasing issues in the standard library #78602

Merged
merged 4 commits into from
Nov 1, 2020
Merged

fix various aliasing issues in the standard library #78602

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed96321
fix aliasing issues in u128 formatting code
RalfJung Oct 31, 2020
9f630af
fix aliasing issue in unix sleep function
RalfJung Oct 31, 2020
607076e
fix aliasing issue in binary_heap
RalfJung Oct 31, 2020
9749eb7
fix aliasing issues in SipHasher
RalfJung Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix aliasing issue in binary_heap
  • Loading branch information
@RalfJung
RalfJung committed Oct 31, 2020
commit 607076e20903bb5267d5d8f2bc7520ba1686cec8
5 changes: 3 additions & 2 deletions library/alloc/src/collections/binary_heap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,8 +1036,9 @@ impl<'a, T> Hole<'a, T> {
debug_assert!(index != self.pos);
debug_assert!(index < self.data.len());
unsafe {
let index_ptr: *const _ = self.data.get_unchecked(index);
let hole_ptr = self.data.get_unchecked_mut(self.pos);
let ptr = self.data.as_mut_ptr();
let index_ptr: *const _ = ptr.add(index);
let hole_ptr = ptr.add(self.pos);
ptr::copy_nonoverlapping(index_ptr, hole_ptr, 1);
}
self.pos = index;
Expand Down