Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miri: remove an outdated FIXME #70769

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Miri: remove an outdated FIXME #70769

merged 1 commit into from
Apr 5, 2020

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 4, 2020

We even have a test making sure that we detect dropping with a non-const implementation.

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 5, 2020

📌 Commit e901b2f has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2020
@RalfJung
Copy link
Member Author

RalfJung commented Apr 5, 2020

r? @Dylan-DPC to reflect review

@rust-highfive rust-highfive assigned Dylan-DPC-zz and unassigned oli-obk Apr 5, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#70558 (Fix some aliasing issues in Vec)
 - rust-lang#70760 (docs: make the description of Result::map_or more clear)
 - rust-lang#70769 (Miri: remove an outdated FIXME)
 - rust-lang#70776 (clarify comment in RawVec::into_box)
 - rust-lang#70806 (fix Miri assignment sanity check)

Failed merges:

r? @ghost
@bors bors merged commit 2448a23 into rust-lang:master Apr 5, 2020
@RalfJung RalfJung deleted the fixed branch April 5, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants