Miri: Provide pointer forcing methods for MemPlace and Op #62441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods for mplace and op to avoid repeated int-to-ptr casting during validation. Also change Memory::copy to work on `Pointer` instead of `Scalar`. Also rename some methods from to_* to assert_* that will panic if their precondition is not met.
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
Normalziation does not work well for dyamically sized types
This was referenced Jul 6, 2019
|
@bors r+ |
|
📌 Commit ac4f6ab has been approved by |
|
Heh, you should enjoy your vacation, not work. ;) But thanks! <3 |
bors
added a commit
that referenced
this pull request
Jul 10, 2019
Miri: Provide pointer forcing methods for MemPlace and Op These are useful when one wants to to a lot of work with some place or operand and not to int-to-ptr casts all the time. In particular, this is needed to fix some test failures in Miri: we need to normalize before starting a visitor that walks a run-time value, so that we can later be sure (during the visitor walk) that we have a proper `Pointer`. Also see the Miri side at rust-lang/miri#830. Cc @eddyb @oli-obk
|
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Jul 10, 2019
Fix validation and reborrowing of integer pointers Depends on rust-lang/rust#62441
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Jul 11, 2019
Fix validation and reborrowing of integer pointers Depends on rust-lang/rust#62441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are useful when one wants to to a lot of work with some place or operand and not to int-to-ptr casts all the time. In particular, this is needed to fix some test failures in Miri: we need to normalize before starting a visitor that walks a run-time value, so that we can later be sure (during the visitor walk) that we have a proper
Pointer.Also see the Miri side at rust-lang/miri#830.
Cc @eddyb @oli-obk