Use arenas to avoid Lrc in queries #2 #59545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
changed the title
|
☔ The latest upstream changes (presumably #59561) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors try |
|
⌛ Trying commit 96911df87970cff6f2611031c71d2244ca13e506 with merge d8b5f7bcf28ee86c3d092848225fcb3424968d5c... |
|
☀️ Try build successful - checks-travis |
|
@rust-timer build d8b5f7bcf28ee86c3d092848225fcb3424968d5c |
|
Success: Queued d8b5f7bcf28ee86c3d092848225fcb3424968d5c with parent cee58fd, comparison URL. |
|
Finished benchmarking try commit d8b5f7bcf28ee86c3d092848225fcb3424968d5c |
|
r? @michaelwoerister / @eddyb |
|
☔ The latest upstream changes (presumably #59949) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors try |
|
⌛ Trying commit e041ac19e2d8737ea123fb573556e5aa28db5fe3 with merge 7e6956719d959a4c959872d365947c6567474174... |
|
@bors r=eddyb,michaelwoerister |
|
📌 Commit d46e732 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 23, 2019
…erister Use arenas to avoid Lrc in queries rust-lang#2 The `Remove subtle Default impl for Value` makes the compilation stop due earlier due to cycle errors, since there's no longer a default value to continue the compilation with. Based on rust-lang#59540.
|
⌛ Testing commit d46e732 with merge 3e51d75c18a766606714858513d347973ac1e4bc... |
|
@bors retry |
bors
added a commit
that referenced
this pull request
May 24, 2019
Rollup of 6 pull requests Successful merges: - #59545 (Use arenas to avoid Lrc in queries #2) - #61054 (Suggest dereferencing on assignment to mutable borrow) - #61056 (tweak discriminant on non-nullary enum diagnostic) - #61082 (fix dangling reference in Vec::append) - #61086 (Box::into_unique: do the reborrow-to-raw *after* destroying the Box) - #61098 (Fix overflowing literal lint in loops) Failed merges: r? @ghost
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
phansch
added a commit
to phansch/rust-clippy
that referenced
this pull request
May 24, 2019
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
May 24, 2019
Rustup to rust-lang/rust#59545 Needed due to signature changes of `item_children` in [the PR](https://github.com/rust-lang/rust/pull/59545/files) (just grep for `item_children` to see the changes) I'm not really sure where the .stderr changes came from.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 25, 2019
Changes: ```` Rustup to rust-lang#61026 rustup rust-lang#60803 Rustup to rust-lang#59545 Rustup to rust-lang#60965 clippy: bump rustc_tools util version to 0.2 rustc_tools_util: fix typo in docs (readme) rustc_tool_utils: bump version to 0.2.0 update if_chain to 1.0.0 tests: update needless_bool test stderr cargo fmt Rustup to rust-lang#60740 Lifetimes UI test cleanup ````
Manishearth
pushed a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jun 7, 2019
37 tasks
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 28, 2019
Changes: ```` travis: temporarily disable rustfmt ci check until rust-lang#4742 is resolved rustup rust-lang#65792 Fix ICE rust-lang#4579 Add regression test for ICE rust-lang#4579 Run update_lints for Unicode lint Re-add false positive check Add raw string regression test for useless_format lint Re-factor useless_format lint Update Unicode lint tests [Backported] Rustup to rust-lang#59545 ```` Fixes #rust-lang#65888
bors
added a commit
that referenced
this pull request
Oct 29, 2019
submodules: update clippy from 66df92a to c8e3cfb Changes: ```` travis: temporarily disable rustfmt ci check until #4742 is resolved rustup #65792 Fix ICE #4579 Add regression test for ICE #4579 Run update_lints for Unicode lint Re-add false positive check Add raw string regression test for useless_format lint Re-factor useless_format lint Update Unicode lint tests [Backported] Rustup to #59545 ```` Fixes #65888 r? @oli-obk @Manishearth
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Changes: ```` travis: temporarily disable rustfmt ci check until rust-lang#4742 is resolved rustup rust-lang/rust#65792 Fix ICE rust-lang#4579 Add regression test for ICE rust-lang#4579 Run update_lints for Unicode lint Re-add false positive check Add raw string regression test for useless_format lint Re-factor useless_format lint Update Unicode lint tests [Backported] Rustup to rust-lang/rust#59545 ```` Fixes ##65888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Remove subtle Default impl for Valuemakes the compilation stop due earlier due to cycle errors, since there's no longer a default value to continue the compilation with.Based on #59540.