Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix str mutating through a ptr derived from &self #58200

Merged
merged 4 commits into from
Feb 13, 2019
Merged

fix str mutating through a ptr derived from &self #58200

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
346dc37
fix str mutating through a ptr derived from &self
RalfJung Feb 5, 2019
13bbba2
remove now-unneeded raw ptr casts
RalfJung Feb 6, 2019
a996f2c
add tracking issue
RalfJung Feb 6, 2019
66c894e
also fix bad use of shared ref in split_at_mut
RalfJung Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
also fix bad use of shared ref in split_at_mut
  • Loading branch information
@RalfJung
RalfJung committed Feb 7, 2019
commit 66c894e07f95a324a39bb4c281c8db4c8842689b
2 changes: 1 addition & 1 deletion src/libcore/str/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2516,7 +2516,7 @@ impl str {
// is_char_boundary checks that the index is in [0, .len()]
if self.is_char_boundary(mid) {
let len = self.len();
let ptr = self.as_ptr() as *mut u8;
let ptr = self.as_mut_ptr();
unsafe {
(from_utf8_unchecked_mut(slice::from_raw_parts_mut(ptr, mid)),
from_utf8_unchecked_mut(slice::from_raw_parts_mut(
Expand Down