Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VecDeque: fix for stacked borrows #56161

Merged
merged 3 commits into from
Dec 13, 2018
Merged

VecDeque: fix for stacked borrows #56161

merged 3 commits into from
Dec 13, 2018

Commits on Dec 7, 2018

  1. Unique/NonNull::from: make sure we convert to raw pointers ASAP 

    By going through a shared reference, we share the destination as read-only, meaning we can read but not write with the raw pointers
    @RalfJung
    RalfJung committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    21b5950 View commit details
    Browse the repository at this point in the history

  2. VecDeque::drain: make sure the 'drain' raw pointer is actually still … 

    …usable
    @RalfJung
    RalfJung committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    b0c4a35 View commit details
    Browse the repository at this point in the history

  3. Drain only needs a shared reference

    @RalfJung
    RalfJung committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    feb775c View commit details
    Browse the repository at this point in the history