Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some repr-rust improvements. #27556

Merged
merged 1 commit into from
Aug 6, 2015
Merged

Conversation

taliesinb
Copy link

  • Some clarifying rephrasing.
  • Rename B.x back to B.a.
  • Make null pointer optimization section bit more concrete.

r? @gankro

* Some clarifying rephrasing.
* Rename B.x back to B.a.
* Make null pointer optimization section bit more concrete.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gankro (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Aatch Aatch changed the title Some rerp-rust improvements. Some repr-rust improvements. Aug 6, 2015
@taliesinb
Copy link
Author

Sorry this took a while, got sidetracked by work. Hope to finish the rest of the nomicon and create PRs as I go over the next few weeks.

@Gankra
Copy link
Contributor

Gankra commented Aug 6, 2015

@bors r+ rollup

Thanks so much for being so perseverant!

@bors
Copy link
Contributor

bors commented Aug 6, 2015

📌 Commit 2ca3dda has been approved by Gankro

@bors
Copy link
Contributor

bors commented Aug 6, 2015

⌛ Testing commit 2ca3dda with merge fb92de7...

bors added a commit that referenced this pull request Aug 6, 2015
* Some clarifying rephrasing.
* Rename B.x back to B.a.
* Make null pointer optimization section bit more concrete.

r? @gankro
@bors bors merged commit 2ca3dda into rust-lang:master Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants