Cleanup compiletest dylib name calculation #127962
Merged
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
A-testsuite
rustbot
added
S-blocked
rust-cloud-vms
bot
force-pushed
the
cleanup-dll-compiletest
branch
from
b654668
to
3855c54
Compare
|
@rustbot ready (rebased) |
rustbot
added
S-waiting-on-review
fmease
approved these changes
Jul 23, 2024
|
r? fmease @bors r+ rollup |
bors
added
S-waiting-on-bors
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 23, 2024
…r=fmease
Cleanup compiletest dylib name calculation
Use `std::env::consts::{DLL_PREFIX, DLL_EXTENSION}` for dylib name calculation which is more accurate for the various different platforms, and is more likely to be looked at by target maintainers.
cc `@bzEq` (as this impacts how compiletest handles AIX dll extensions)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 23, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#124895 (Disallow hidden references to mutable static) - rust-lang#125834 (treat `&raw (const|mut) UNSAFE_STATIC` implied deref as safe) - rust-lang#126898 (Migrate `run-make/link-framework` to `rmake.rs`) - rust-lang#127962 (Cleanup compiletest dylib name calculation) - rust-lang#127990 (Migrate `lto-linkage-used-attr`, `no-duplicate-libs` and `pgo-gen-no-imp-symbols` `run-make` tests to rmake) - rust-lang#128067 (Get rid of `can_eq_shallow`) - rust-lang#128076 (Get rid of `InferCtxtExt` from `error_reporting::traits`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 23, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#125834 (treat `&raw (const|mut) UNSAFE_STATIC` implied deref as safe) - rust-lang#127962 (Cleanup compiletest dylib name calculation) - rust-lang#128049 (Reword E0626 to mention static coroutine, add structured suggestion for adding `static`) - rust-lang#128067 (Get rid of `can_eq_shallow`) - rust-lang#128076 (Get rid of `InferCtxtExt` from `error_reporting::traits`) - rust-lang#128089 (std: Unsafe-wrap actually-universal platform code) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 23, 2024
Rollup merge of rust-lang#127962 - jieyouxu:cleanup-dll-compiletest, r=fmease Cleanup compiletest dylib name calculation Use `std::env::consts::{DLL_PREFIX, DLL_EXTENSION}` for dylib name calculation which is more accurate for the various different platforms, and is more likely to be looked at by target maintainers. cc ``@bzEq`` (as this impacts how compiletest handles AIX dll extensions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
std::env::consts::{DLL_PREFIX, DLL_EXTENSION}for dylib name calculation which is more accurate for the various different platforms, and is more likely to be looked at by target maintainers.cc @bzEq (as this impacts how compiletest handles AIX dll extensions)