Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable some windows tests #127715

Merged
merged 1 commit into from
Jul 21, 2024
Merged

reenable some windows tests #127715

merged 1 commit into from
Jul 21, 2024

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jul 14, 2024

Locally passing on x86_64-pc-windows-msvc, fingers crossed for *-pc-windows-gnu.

try-job: x86_64-msvc
try-job: x86_64-mingw

@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jul 14, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2024
reenable some windows tests

Locally passing on `x86_64-pc-windows-msvc`, fingers crossed for `*-pc-windows-gnu`.

try-job: x86_64-msvc
try-job: x86_64-mingw
@bors
Copy link
Contributor

bors commented Jul 14, 2024

⌛ Trying commit b90ee2a with merge d4f2f41...

@bors
Copy link
Contributor

bors commented Jul 14, 2024

☀️ Try build successful - checks-actions
Build commit: d4f2f41 (d4f2f41fe22da27e95fbe714a7b192c06a6ae3ae)

@workingjubilee workingjubilee added the O-windows Operating system: Windows label Jul 17, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 20, 2024

📌 Commit b90ee2a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2024
@Mark-Simulacrum
Copy link
Member

@bors rollup=iffy

@bors
Copy link
Contributor

bors commented Jul 21, 2024

⌛ Testing commit b90ee2a with merge a62ac15...

@bors
Copy link
Contributor

bors commented Jul 21, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing a62ac15 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2024
@bors bors merged commit a62ac15 into rust-lang:master Jul 21, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 21, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a62ac15): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.026s -> 769.061s (-0.25%)
Artifact size: 328.78 MiB -> 328.87 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants