Better handle suggestions for the already present code and fix some suggestions #126818
+76
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy HIR ty lowering was modified cc @fmease |
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
suggestions-fix
branch
from
2c92ade
to
ecfde6e
Compare
flip1995
reviewed
Jun 24, 2024
|
☔ The latest upstream changes (presumably #127296) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
force-pushed
the
suggestions-fix
branch
from
ecfde6e
to
aea2e39
Compare
|
☔ The latest upstream changes (presumably #127898) made this pull request unmergeable. Please resolve the merge conflicts. |
When a suggestion part is for already present code, do not highlight it. If after that there are no highlights left, do not show the suggestion at all.
estebank
force-pushed
the
suggestions-fix
branch
from
aea2e39
to
fcaa2c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a suggestion part is for code that is already present, skip it. If all the suggestion parts for a suggestion are for code that is already there, do not emit the suggestion.
Fix two suggestions that treat
span_suggestionas if it werespan_help.