std::unix::stack_overflow::drop_handler addressing todo through libc …

[devnexen]

…update

[rustbot]

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[joboet]

The constant does not exist on Android yet, I believe, so we still need the workaround. But maybe you could gate it to be Android-only?

[devnexen]

ah true, I misread one level of the libc crate.

[joboet]

Thank you!
@bors r+ rollup
r? joboet

[bors]

📌 Commit 0e02247 has been approved by joboet

It is now in the queue for this repository.

[workingjubilee]

huh? why is this constant not available on both android and linux?

[workingjubilee]

That FIXME was for removing a novel definition, not merely using cfg for one. This constant is invariant across all Linux architectures and kernels since its definition, so I don't know how I fucked up adding it to Android, but it should not be different there. Adding 3 lines of cfg noise is not what I intended, it is not an improvement, and it should not be accepted.

r? @workingjubilee

[workingjubilee]

@bors r-

[devnexen]

adding here

[workingjubilee]

Thank you.

[bors]

☔ The latest upstream changes (presumably #127153) made this pull request unmergeable. Please resolve the merge conflicts.

[Dylan-DPC]

@devnexen any updates on this? thanks

[devnexen]

Well I see it is fixed on libc main branch only but not the stable branch I ll see for a backport.