[beta] backports #126093

cuviper · 2024-06-06T19:07:39Z

Fix insufficient logic when searching for the underlying allocation Fix insufficient logic when searching for the underlying allocation #124761
Handle field projections like slice indexing in invalid_reference_casting Handle field projections like slice indexing in invalid_reference_casting #124908
Handle Deref expressions in invalid_reference_casting Handle Deref expressions in invalid_reference_casting #124978
Fix ICE in non-operand aggregate_raw_ptr instrinsic codegen Fix ICE in non-operand aggregate_raw_ptr intrinsic codegen #125184
Wrap Context.ext in AssertUnwindSafe Wrap Context.ext in AssertUnwindSafe #125392
Revert problematic opaque type change Revert problematic opaque type change #125489
ast: Revert a breaking attribute visiting order change ast: Revert a breaking attribute visiting order change #125734
Update to LLVM 18.1.7 Update to LLVM 18.1.7 #126061
Revert "Disallow ambiguous attributes on expressions" on beta [beta] Revert "Disallow ambiguous attributes on expressions" on beta #126102 / Revert "Disallow ambiguous attributes on expressions" on nightly #126101
Silence double-symlink errors while building solaris toolchain Silence double-symlink errors while building solaris toolchain #126011

r? cuviper

in the `invalid_reference_casting` lint, when trying to lint on bigger memory layout casts. (cherry picked from commit cd6a0c8)

…ting (cherry picked from commit 0ca1a94)

(cherry picked from commit 2bb25d3)

(cherry picked from commit f60f2e8)

(cherry picked from commit 3a21fb5)

…s7, r=compiler-errors" This reverts commit f939d1f, reversing changes made to 183c706. (cherry picked from commit 56c135c)

(cherry picked from commit 526090b)

(cherry picked from commit 3c4066d)

(cherry picked from commit 6e67eaa)

(cherry picked from commit 46b31e6)

rustbot · 2024-06-06T19:07:46Z

⚠️ Warning ⚠️

Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
These commits modify submodules.

cuviper · 2024-06-06T19:09:34Z

@bors r+ rollup=never p=1

bors · 2024-06-06T19:09:36Z

📌 Commit ac45caa has been approved by cuviper

It is now in the queue for this repository.

[beta] backports - Fix insufficient logic when searching for the underlying allocation rust-lang#124761 - Handle field projections like slice indexing in invalid_reference_casting rust-lang#124908 - Handle Deref expressions in invalid_reference_casting rust-lang#124978 - Fix ICE in non-operand `aggregate_raw_ptr` instrinsic codegen rust-lang#125184 - Wrap Context.ext in AssertUnwindSafe rust-lang#125392 - Revert problematic opaque type change rust-lang#125489 - ast: Revert a breaking attribute visiting order change rust-lang#125734 - Update to LLVM 18.1.7 rust-lang#126061 r? cuviper

bors · 2024-06-07T00:36:17Z

⌛ Testing commit ac45caa with merge 49f3109...

bors · 2024-06-07T00:49:16Z

💔 Test failed - checks-actions

lqd · 2024-06-07T01:09:24Z

As seen in #126102 which failed as well, I think we need to backport the CI fix #126011

workingjubilee · 2024-06-07T01:11:40Z

Correct.

cuviper · 2024-06-07T01:12:09Z

Ok, I can pull that as well as your other backport.

…xpr-attrs, r=davidtwco" This reverts commit 57dad1d, reversing changes made to 36316df.

workingjubilee · 2024-06-07T01:13:12Z

Should only need 40291bc

(cherry picked from commit 40291bc)

cuviper · 2024-06-07T01:17:27Z

@bors r+

bors · 2024-06-07T01:17:28Z

📌 Commit c689624 has been approved by cuviper

It is now in the queue for this repository.

bors · 2024-06-07T02:39:17Z

⌛ Testing commit c689624 with merge f4d7315...

[beta] backports - Fix insufficient logic when searching for the underlying allocation rust-lang#124761 - Handle field projections like slice indexing in invalid_reference_casting rust-lang#124908 - Handle Deref expressions in invalid_reference_casting rust-lang#124978 - Fix ICE in non-operand `aggregate_raw_ptr` instrinsic codegen rust-lang#125184 - Wrap Context.ext in AssertUnwindSafe rust-lang#125392 - Revert problematic opaque type change rust-lang#125489 - ast: Revert a breaking attribute visiting order change rust-lang#125734 - Update to LLVM 18.1.7 rust-lang#126061 - Revert "Disallow ambiguous attributes on expressions" on beta rust-lang#126102 / rust-lang#126101 - Silence double-symlink errors while building solaris toolchain rust-lang#126011 r? cuviper

Revert "Disallow ambiguous attributes on expressions" on nightly As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 to fix P-critical beta regressions rust-lang#125199. r? `@wesleywiser` Opening as draft so that `@wesleywiser` and `@apiraino,` you can tell me whether you wanted: 1. a `beta-accepted` revert of rust-lang#124099 on nightly (this PR)? That will need to be backported to beta (even though rust-lang#126093 may be the last of those) 2. a revert of rust-lang#124099 on beta? 3. all of the above? I also opened rust-lang#126102, another draft PR to revert rust-lang#124099 on beta, should you choose options 2 or 3.

rust-log-analyzer · 2024-06-07T03:19:48Z

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-06-07T03:20:20Z

💔 Test failed - checks-actions

Revert "Disallow ambiguous attributes on expressions" on nightly As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 to fix P-critical beta regressions rust-lang#125199. r? ``@wesleywiser`` Opening as draft so that ``@wesleywiser`` and ``@apiraino,`` you can tell me whether you wanted: 1. a `beta-accepted` revert of rust-lang#124099 on nightly (this PR)? That will need to be backported to beta (even though rust-lang#126093 may be the last of those) 2. a revert of rust-lang#124099 on beta? 3. all of the above? I also opened rust-lang#126102, another draft PR to revert rust-lang#124099 on beta, should you choose options 2 or 3.

cuviper · 2024-06-07T04:17:24Z

@bors retry

Rollup merge of rust-lang#126101 - lqd:revert-124099, r=wesleywiser Revert "Disallow ambiguous attributes on expressions" on nightly As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 to fix P-critical beta regressions rust-lang#125199. r? ``@wesleywiser`` Opening as draft so that ``@wesleywiser`` and ``@apiraino,`` you can tell me whether you wanted: 1. a `beta-accepted` revert of rust-lang#124099 on nightly (this PR)? That will need to be backported to beta (even though rust-lang#126093 may be the last of those) 2. a revert of rust-lang#124099 on beta? 3. all of the above? I also opened rust-lang#126102, another draft PR to revert rust-lang#124099 on beta, should you choose options 2 or 3.

bors · 2024-06-07T11:26:31Z

⌛ Testing commit c689624 with merge 7bb6510...

bors · 2024-06-07T14:13:24Z

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 7bb6510 to beta...

Revert "Disallow ambiguous attributes on expressions" on nightly As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 to fix P-critical beta regressions rust-lang#125199. r? ``@wesleywiser`` Opening as draft so that ``@wesleywiser`` and ``@apiraino,`` you can tell me whether you wanted: 1. a `beta-accepted` revert of rust-lang#124099 on nightly (this PR)? That will need to be backported to beta (even though rust-lang#126093 may be the last of those) 2. a revert of rust-lang#124099 on beta? 3. all of the above? I also opened rust-lang#126102, another draft PR to revert rust-lang#124099 on beta, should you choose options 2 or 3.

Urgau and others added 10 commits June 6, 2024 11:41

Fix insufficient logic when searching for the underlying allocation

bd642ed

in the `invalid_reference_casting` lint, when trying to lint on bigger memory layout casts. (cherry picked from commit cd6a0c8)

Handle field projections like slice indexing in invalid_reference_cas…

eb89434

…ting (cherry picked from commit 0ca1a94)

Handle Deref expressions in invalid_reference_casting

900f1b7

(cherry picked from commit 2bb25d3)

Fix ICE in non-operand aggregate_raw_ptr instrinsic codegen

3c51206

(cherry picked from commit f60f2e8)

Wrap Context.ext in AssertUnwindSafe

b8fb165

(cherry picked from commit 3a21fb5)

Revert "Rollup merge of rust-lang#123979 - oli-obk:define_opaque_type…

97e94c1

…s7, r=compiler-errors" This reverts commit f939d1f, reversing changes made to 183c706. (cherry picked from commit 56c135c)

Add regression tests

4fa46ff

(cherry picked from commit 526090b)

Add a test for resolving macro_rules calls inside attributes

d0b0474

(cherry picked from commit 3c4066d)

ast: Revert a breaking attribute visiting order change

619e9ab

(cherry picked from commit 6e67eaa)

Update to LLVM 18.1.7

ac45caa

(cherry picked from commit 46b31e6)

rustbot assigned cuviper Jun 6, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 6, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2024

lqd mentioned this pull request Jun 6, 2024

Revert "Disallow ambiguous attributes on expressions" on nightly #126101

Merged

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2024

Revert "Rollup merge of rust-lang#124099 - voidc:disallow-ambiguous-e…

7a24e8b

…xpr-attrs, r=davidtwco" This reverts commit 57dad1d, reversing changes made to 36316df.

Silence double-symlink errors while building solaris toolchain

c689624

(cherry picked from commit 40291bc)

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 7, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2024

workingjubilee mentioned this pull request Jun 7, 2024

[beta] Revert "Disallow ambiguous attributes on expressions" on beta #126102

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2024

bors merged commit 7bb6510 into rust-lang:beta Jun 7, 2024
11 checks passed

rustbot added this to the 1.79.0 milestone Jun 7, 2024

This was referenced Jun 7, 2024

Regression when doc string invokes a macro which is defined within the same module #124535

Closed

regression: ambiguous outer attributes #125199

Closed

cuviper deleted the beta-next branch June 14, 2024 01:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[beta] backports #126093

[beta] backports #126093

cuviper commented Jun 6, 2024 •

edited

Loading

rustbot commented Jun 6, 2024

cuviper commented Jun 6, 2024

bors commented Jun 6, 2024

bors commented Jun 7, 2024

This comment has been minimized.

bors commented Jun 7, 2024

lqd commented Jun 7, 2024

workingjubilee commented Jun 7, 2024

cuviper commented Jun 7, 2024

workingjubilee commented Jun 7, 2024

cuviper commented Jun 7, 2024

bors commented Jun 7, 2024

bors commented Jun 7, 2024

rust-log-analyzer commented Jun 7, 2024

bors commented Jun 7, 2024

cuviper commented Jun 7, 2024

bors commented Jun 7, 2024

bors commented Jun 7, 2024

[beta] backports #126093

[beta] backports #126093

Conversation

cuviper commented Jun 6, 2024 • edited Loading

rustbot commented Jun 6, 2024

cuviper commented Jun 6, 2024

bors commented Jun 6, 2024

bors commented Jun 7, 2024

This comment has been minimized.

bors commented Jun 7, 2024

lqd commented Jun 7, 2024

workingjubilee commented Jun 7, 2024

cuviper commented Jun 7, 2024

workingjubilee commented Jun 7, 2024

cuviper commented Jun 7, 2024

bors commented Jun 7, 2024

bors commented Jun 7, 2024

rust-log-analyzer commented Jun 7, 2024

bors commented Jun 7, 2024

cuviper commented Jun 7, 2024

bors commented Jun 7, 2024

bors commented Jun 7, 2024

cuviper commented Jun 6, 2024 •

edited

Loading