Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::thread: adding freebsd/netbsd to the linux's get_name implementa… #123233

Merged
merged 1 commit into from
Mar 31, 2024
Merged

std::thread: adding freebsd/netbsd to the linux's get_name implementa… #123233

merged 1 commit into from
Mar 31, 2024

Conversation

devnexen
Copy link
Contributor

…tion.

@rustbot
Copy link
Collaborator

rustbot commented Mar 30, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 30, 2024
joboet
joboet requested changes Mar 30, 2024
View reviewed changes
library/std/src/sys/pal/unix/thread.rs Outdated Show resolved Hide resolved
@joboet joboet assigned joboet and unassigned Mark-Simulacrum Mar 30, 2024
@joboet
Copy link
Member

joboet commented Mar 30, 2024

Cool stuff, thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2024

📌 Commit c749483 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2024
@bors
Copy link
Contributor

bors commented Mar 31, 2024

⌛ Testing commit c749483 with merge 5f358a8...

@bors
Copy link
Contributor

bors commented Mar 31, 2024

☀️ Test successful - checks-actions
Approved by: joboet
Pushing 5f358a8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 31, 2024
@bors bors merged commit 5f358a8 into rust-lang:master Mar 31, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 31, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5f358a8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.332s -> 668.042s (-0.34%)
Artifact size: 315.71 MiB -> 315.71 MiB (0.00%)

devnexen added a commit to devnexen/rust that referenced this pull request Mar 31, 2024
@devnexen
std::thread: adding get_name haiku implementation.
baed5e0 
follow-up rust-lang#123233
@devnexen devnexen mentioned this pull request Mar 31, 2024
Merged
devnexen added a commit to devnexen/rust that referenced this pull request Mar 31, 2024
@devnexen
std::thread: adding get_name haiku implementation.
cd3e345 
follow-up rust-lang#123233
devnexen added a commit to devnexen/rust that referenced this pull request Mar 31, 2024
@devnexen
std::thread: adding get_name haiku implementation.
e5c5ed0 
follow-up rust-lang#123233
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 31, 2024
@workingjubilee
Rollup merge of rust-lang#123267 - devnexen:thread_get_name_haiku, r=…
2a08f02 
…joboet

std::thread: adding get_name haiku implementation.

follow-up rust-lang#123233
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@rust-timer
Unrolled build for rust-lang#123267
9ad6728 
Rollup merge of rust-lang#123267 - devnexen:thread_get_name_haiku, r=joboet

std::thread: adding get_name haiku implementation.

follow-up rust-lang#123233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joboet joboet joboet requested changes

Assignees

@joboet joboet

Labels
merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
6 participants
@devnexen @rustbot @joboet @bors @rust-timer @Mark-Simulacrum