Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize the result of Fields::ty_with_args #123176

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

celinval
Copy link
Contributor

We were only instantiating before, which would leak an AliasTy. I added a test case that reproduce the issue seen here:

model-checking/kani#3113

r? @oli-obk

We were only instantiating before, which would leak an AliasTy.
I added a test case that reproduce the issue seen here:

model-checking/kani#3113
@rustbot
Copy link
Collaborator

rustbot commented Mar 28, 2024

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 28, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Mar 29, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 29, 2024

📌 Commit a325bce has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 29, 2024
Normalize the result of `Fields::ty_with_args`

We were only instantiating before, which would leak an AliasTy. I added a test case that reproduce the issue seen here:

model-checking/kani#3113

r? `@oli-obk`
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123106 (CFI: Abstract Closures and Coroutines)
 - rust-lang#123176 (Normalize the result of `Fields::ty_with_args`)
 - rust-lang#123186 (copy any file from stage0/lib to stage0-sysroot/lib)
 - rust-lang#123187 (Forward port 1.77.1 release notes)
 - rust-lang#123188 (compiler: fix few unused_peekable and needless_pass_by_ref_mut clippy lints)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#123176 (Normalize the result of `Fields::ty_with_args`)
 - rust-lang#123186 (copy any file from stage0/lib to stage0-sysroot/lib)
 - rust-lang#123187 (Forward port 1.77.1 release notes)
 - rust-lang#123188 (compiler: fix few unused_peekable and needless_pass_by_ref_mut clippy lints)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 73a4208 into rust-lang:master Mar 29, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2024
Rollup merge of rust-lang#123176 - celinval:smir-field-ty, r=oli-obk

Normalize the result of `Fields::ty_with_args`

We were only instantiating before, which would leak an AliasTy. I added a test case that reproduce the issue seen here:

model-checking/kani#3113

r? ``@oli-obk``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants