Unconditionally show update nightly hint on ICE #122200

jieyouxu · 2024-03-08T18:34:56Z

Instead of trying to guess if a update nightly hint should be shown (by checking for system time, querying version and channel info etc.), just show the update nightly hint for nightly compilers. This avoids breaking tests that match on ICE test outputs on nightly/dev channels.

Another issue is that the outdated nightly hint triggers for ICE tests, causing a mismatch with the test expectation. There doesn't seem to be any env var to suppress this.

See https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/stage0.20compiletest.20broken/near/425543681 for context.

rustbot · 2024-03-08T18:35:04Z

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2024-03-08T19:52:56Z

@rustbot ready

onur-ozkan · 2024-03-09T15:55:37Z

We should link this PR with #122196 if I am not mistaken?

jieyouxu · 2024-03-09T16:00:09Z

We should link this PR with #122196 if I am not mistaken?

Unfortunately there's 2 separate bugs here:

The ICE message is shown conditionally on a lot of conditions which trigger for some ICE tests when tested via outdated nightly compilers causing the stderr output to differ.
stage0 run-make compiletest broken #122196 is still broken because rmake.rs isn't compiled with --sysroot passed.

cjgillot · 2024-03-10T12:31:51Z

I'm lacking context about this hint.
r? compiler

lcnr · 2024-03-11T08:55:03Z

same 😅
r? compiler

estebank · 2024-03-11T23:57:27Z

tests/ui/impl-trait/equality-in-canonical-query.clone.stderr

@@ -19,5 +19,7 @@ LL | same_output(foo, rpit);
 LL | same_output(foo, rpit);
 | ^^^^^^^^^^^^^^^^^^^^^^

+note: if you are using a nightly compiler, please make sure that you have updated to the latest nightly


Is there any point in having "if you are using a nightly compiler"? Why not check tcx.sess.is_nightly_build() directly?

I thought install_ice_hook and report_ice were so early in rustc_driver_impl that we didn't have a tcx available?

I believe you can use rustc_feature::UnstableFeatures::from_environment(None).is_nightly_build(); for this instead.

estebank · 2024-03-12T00:02:03Z

I feel like we would want to unconditionally suggest updating for nightly releases. On stable I am of many minds. We could do a check for current date and try to figure out how long ago the current release went out, and if >6 weeks, tell the user to consider updating. But that wouldn't take into account dot-releases to fix that exact ICE being released. At the same time, I would expect people to already think "maybe there's a newer version that fixes this". On stable we also need to account for non-rustup distributed rustc, like from Linux distro package managers, which would likely not want such a message, or to customize it...

For now, can you try to check for the current build release channel and remove the uncertain language from the message?

jieyouxu · 2024-03-16T14:52:46Z

For now, can you try to check for the current build release channel and remove the uncertain language from the message?

Hmm, wouldn't this break ICE tests checking for the exact ICE message if the compiler's channel is nightly? (because normally the ICE tests are blessed under some dev channel right, which wouldn't have this message if we gated it based on channel?)

bors · 2024-04-08T16:58:49Z

☔ The latest upstream changes (presumably #123628) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2024-04-08T17:24:43Z

@estebank sorry for the ping, I want to unbork cg_clif's tests. Not sure what to do here, maybe we just emit the update nightly note unconditionally, or revert the update note altogether?

estebank · 2024-04-08T22:28:35Z

@jieyouxu let's check if rustc_feature::UnstableFeatures::from_environment(None).is_nightly_build() works for checking that the ICE isn't happening on a stable release. If it doesn't work, lets land this PR as is.

jieyouxu · 2024-04-08T22:29:20Z

Thanks, I'll try that

bors · 2024-04-09T01:35:34Z

☔ The latest upstream changes (presumably #122077) made this pull request unmergeable. Please resolve the merge conflicts.

estebank · 2024-04-09T16:46:00Z

@bors r+

bors · 2024-04-09T16:46:02Z

📌 Commit 09dab38 has been approved by estebank

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#121884 (Port exit-code run-make test to use rust) - rust-lang#122200 (Unconditionally show update nightly hint on ICE) - rust-lang#123568 (Clean up tests/ui by removing `does-nothing.rs`) - rust-lang#123609 (Don't use bytepos offsets when computing semicolon span for removal) - rust-lang#123612 (Set target-abi module flag for RISC-V targets) - rust-lang#123633 (Store all args in the unsupported Command implementation) - rust-lang#123668 (async closure coroutine by move body MirPass refactoring) Failed merges: - rust-lang#123701 (Only assert for child/parent projection compatibility AFTER checking that theyre coming from the same place) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#122200 - jieyouxu:unconditional-nightly-update-hint, r=estebank Unconditionally show update nightly hint on ICE Instead of trying to guess if a update nightly hint should be shown (by checking for system time, querying version and channel info etc.), just show the update nightly hint for nightly compilers. This avoids breaking tests that match on ICE test outputs on nightly/dev channels. > Another issue is that the outdated nightly hint triggers for ICE tests, causing a mismatch with the test expectation. There doesn't seem to be any env var to suppress this. See <https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/stage0.20compiletest.20broken/near/425543681> for context.

rustbot assigned cjgillot Mar 8, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 8, 2024

This comment has been minimized.

Sign in to view

jieyouxu force-pushed the unconditional-nightly-update-hint branch from 25086d6 to a1cb4c2 Compare March 8, 2024 19:00

This comment has been minimized.

Sign in to view

jieyouxu force-pushed the unconditional-nightly-update-hint branch from a1cb4c2 to 1a9606b Compare March 8, 2024 19:52

rustbot assigned lcnr and unassigned cjgillot Mar 10, 2024

rustbot assigned estebank and unassigned lcnr Mar 11, 2024

estebank reviewed Mar 11, 2024

View reviewed changes

rust-cloud-vms bot force-pushed the unconditional-nightly-update-hint branch from 1a9606b to ec2a36b Compare April 8, 2024 17:19

rust-cloud-vms bot force-pushed the unconditional-nightly-update-hint branch from ec2a36b to 5d8b8b8 Compare April 8, 2024 23:52

jieyouxu added 2 commits April 9, 2024 13:37

driver: unconditionally show update nightly hint

c7e77be

tests: bless ui and rustdoc-ui tests for ICE messages

09dab38

rust-cloud-vms bot force-pushed the unconditional-nightly-update-hint branch from 5d8b8b8 to 09dab38 Compare April 9, 2024 14:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2024

matthiaskrgr mentioned this pull request Apr 10, 2024

Rollup of 7 pull requests #123708

Merged

bors merged commit 7dd24d8 into rust-lang:master Apr 10, 2024
11 checks passed

rustbot added this to the 1.79.0 milestone Apr 10, 2024

jieyouxu deleted the unconditional-nightly-update-hint branch May 27, 2024 13:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unconditionally show update nightly hint on ICE #122200

Unconditionally show update nightly hint on ICE #122200

jieyouxu commented Mar 8, 2024 •

edited

Loading

rustbot commented Mar 8, 2024

This comment has been minimized.

This comment has been minimized.

jieyouxu commented Mar 8, 2024 •

edited

Loading

onur-ozkan commented Mar 9, 2024

jieyouxu commented Mar 9, 2024 •

edited

Loading

cjgillot commented Mar 10, 2024

lcnr commented Mar 11, 2024

estebank Mar 11, 2024

jieyouxu Mar 12, 2024

estebank Apr 8, 2024

estebank commented Mar 12, 2024

jieyouxu commented Mar 16, 2024 •

edited

Loading

bors commented Apr 8, 2024

jieyouxu commented Apr 8, 2024

estebank commented Apr 8, 2024

jieyouxu commented Apr 8, 2024

bors commented Apr 9, 2024

estebank commented Apr 9, 2024

bors commented Apr 9, 2024

Unconditionally show update nightly hint on ICE #122200

Unconditionally show update nightly hint on ICE #122200

Conversation

jieyouxu commented Mar 8, 2024 • edited Loading

rustbot commented Mar 8, 2024

This comment has been minimized.

This comment has been minimized.

jieyouxu commented Mar 8, 2024 • edited Loading

onur-ozkan commented Mar 9, 2024

jieyouxu commented Mar 9, 2024 • edited Loading

cjgillot commented Mar 10, 2024

lcnr commented Mar 11, 2024

estebank Mar 11, 2024

Choose a reason for hiding this comment

jieyouxu Mar 12, 2024

Choose a reason for hiding this comment

estebank Apr 8, 2024

Choose a reason for hiding this comment

estebank commented Mar 12, 2024

jieyouxu commented Mar 16, 2024 • edited Loading

bors commented Apr 8, 2024

jieyouxu commented Apr 8, 2024

estebank commented Apr 8, 2024

jieyouxu commented Apr 8, 2024

bors commented Apr 9, 2024

estebank commented Apr 9, 2024

bors commented Apr 9, 2024

jieyouxu commented Mar 8, 2024 •

edited

Loading

jieyouxu commented Mar 8, 2024 •

edited

Loading

jieyouxu commented Mar 9, 2024 •

edited

Loading

jieyouxu commented Mar 16, 2024 •

edited

Loading